Set release date for 2.4

Ref #605

.github/issue_template.md

@@ -0,0 +1,11 @@
+# Issue Checks
+
+Prior to submitting a new issue make sure to complete these steps:
+
+1. Checkout the `dev` branch and confirm the issue is present there as well.
+   The `dev` branch contains fixes that may not have been merged to `master` yet.
+2. Post the syntax you are using (default/mediawiki/markdown) **and** your vimwiki settings from your `.vimrc`
+3. Provide a detailed description of the problem including **steps to reproduce the issue**.
+4. Include the output of `:VimwikiShowVersion`.
+
+**DELETE THIS TEMPLATE TEXT PRIOR TO SUBMITTING THE ISSUE**

.github/pull_request_template.md

@@ -0,0 +1,9 @@
+# Pull Request Checks
+
+1. **ALL** pull requests should be made against the `dev` branch!
+2. Take a look at [CONTRIBUTING.MD](https://github.com/vimwiki/vimwiki/blob/dev/CONTRIBUTING.md)
+3. Reference any related issues.
+4. Provide a description of the proposed changes and any testing that was done.
+5. Make sure to update the documentation in `doc/vimwiki.txt` if applicable.
+
+**DELETE THIS TEMPLATE TEXT PRIOR TO SUBMITTING YOUR PULL REQUEST**

CONTRIBUTING.md

@@ -10,14 +10,23 @@ If you want to provide a pull request on GitHub, please start from the `dev` bra
 `master` branch. (Caution, GitHub shows `master` as the default branch from which to start a PR.)
 
 
-# More info for (aspiring) core developers
+# More info and advice for (aspiring) core developers
+- Before implementing a non-trivial feature, think twice what it means for the user. We should
+  always try to keep backward compatiblility. If you are not sure, discuss it on GitHub.
+- Also, when thinking about adding a new feature, it should be something which fits into the
+  overall design of Vimwiki and which a significant portion of the users may like. Keep in mind
+  that everybody has their own way to use Vimwiki.
+- Keep the coding style consistent.
+- Test your changes. Keep in mind that Vim has a ton of options and the users tons of different
+  setups. Take a little time to think about under which circumstances your changes could break.
+
 ## Git branching model
 - there are two branches with eternal lifetime:
     - `dev`: This is where the main development happens. Tasks which are done in one or only a few
       commits go here directly. Always try to keep this branch in a working state, that is, if the
       task you work on requires multiple commits, make sure intermediate commits don't make Vimwiki
       unusable (or at least push these commits at one go).
-    - `master`: This branches is for released states only. Whenever a reasonable set of changes has
+    - `master`: This branch is for released states only. Whenever a reasonable set of changes has
       piled up in the `dev` branch, a [release is done](#Preparing a release). After a release,
       `dev` has been merged into `master` and `master` got exactly one additional commit in which
       the version number in `plugin/vimwiki.vim` is updated. Apart from these commits and the merge

README-cn.md

@@ -1,63 +1,62 @@
-一个私人的维基——vim插件
+VimWiki —— Vim 个人 Wiki 插件
 ==============================================================================
 
+[English](README.md)
+
 ![screenshot1](doc/screenshot_1.png)
-![screenshot2](doc/screenshot_2.png)
+![screenshot2](doc/screenshot_2.png) *
 
 介绍
 ------------------------------------------------------------------------------
 
-Vimwiki是私人维基的vim插件 -- 许多有自己代码高亮的text文件。
+Vimwiki 是 Vim 中的个人 Wiki —— 一组链接起来的、有独特语法高亮的文本文件。
 
-通过Vimwiki，你可以:
+通过 Vimwiki，你可以:
 
  * 组织笔记和想法
- * 制作代办事项表
+ * 管理待办事项
- * 写文档
+ * 编写文档
+ * 坚持写日记
+ * 将这一切导出成 HTML 网页
 
-一个快速的开始，通常使用`<Leader>ww`(一般是`\ww`)，然后创建你的index wiki文件。
+马上开始！按下 `<Leader>ww`（通常是 `\ww`）进入作为目录页的 wiki 文件，这个文件默认存放在 `~/vimwiki/index.wiki`。
-通常，它在:
 
-    ~/vimwiki/index.wiki
+在该文件中输入以下示例：
 
-在这个文件，输入如下的例子：
+    = 我的个人知识库 =
+        * 任务列表 -- _昨天_ 就该完成的事！！！
+        * Gutenberg 计划 -- 好书给我力量。
+        * 草稿 -- 临时记录一些东西。
 
-    = My knowledge base =
+把光标移到 `任务` 二字上，按 Enter（回车）创建链接。按下后，`任务`二字会变成 `[[任务]]` —— 这是一个 Vimwiki 链接。再次按 Enter 即可进入这个链接（打开新的 wiki 文件）。编辑这个新文件，保存，然后按 Backspace（退格）就能回到目录页。
-        * Tasks -- things to be done _yesterday_!!!
-        * Project Gutenberg -- good books are power.
-        * Scratchpad -- various temporary stuff.
 
-将你的光标放到`Tasks`（任务）上，并且按回车键去创建一个链接。一旦按下，`Task`将会
+如果 Vimwiki 链接长度不止一个单词（指的是英文单词），只需在 Visual 模式选择这段文本后按 Enter 即可。用上面的 `Gutenberg 计划` 试试吧。最终结果是这样：
-变成`[[Tasks]]` -- 一个vimwiki的链接。再按一次回车去打开它。编辑文件，保存它，
-然后按backspace来返回你的index。
 
-一个vimwiki链接可以一句话创建。只需要通过选择visual模式选择这个句子，然后按回车。
+    = 我的个人知识库 =
-你可以通过选择`Project Gutenberg`来尝试。结果像是这个样子：
+        * [[任务列表]] -- _昨天_ 就该完成的事！！！
-
+        * [[Gutenberg 计划]] -- 好书给我力量。
-    = My knowledge base =
+        * 草稿 -- 临时记录一些东西。
-        * [[Tasks]] -- things to be done _yesterday_!!!
-        * [[Project Gutenberg]] -- good books are power.
-        * Scratchpad -- various temporary stuff.
 
 
 基本标记
 ------------------------------------------------------------------------------
 
-    = Header1 =
+    = 一级标题 =
-    == Header2 ==
+    == 二级标题 ==
-    === Header3 ===
+    === 三级标题 ===
 
 
-    *bold* -- bold text
+    *bold* -- 粗体文本
-    _italic_ -- italic text
+    _italic_ -- 斜体文本
+    （应用于句中的汉字文本时，必须在标记前后加空格，例如：一段 *中文* 文本）
 
-    [[wiki link]] -- wiki link
+    [[wiki link]] -- wiki 链接
-    [[wiki link|description]] -- wiki link with description
+    [[wiki link|description]] -- 带有描述文本的 wiki 链接
 
 
-列表:
+列表：
 
-    * bullet list item 1
+    * bullet list item 1（无编号列表）
         - bullet list item 2
         - bullet list item 3
             * bullet list item 4
@@ -67,13 +66,13 @@ Vimwiki是私人维基的vim插件 -- 许多有自己代码高亮的text文件
         - bullet list item 8
         - bullet list item 9
 
-    1. numbered list item 1
+    1. numbered list item 1（有编号列表）
     2. numbered list item 2
         a) numbered list item 3
         b) numbered list item 4
 
 
-查看`:h vimwiki-syntax`
+更多格式说明，请阅 `:h vimwiki-syntax`
 
 
 键位绑定
@@ -81,46 +80,49 @@ Vimwiki是私人维基的vim插件 -- 许多有自己代码高亮的text文件
 
 normal 模式:
 
- * `<Leader>ww` -- 打开默认的wiki index文件
+ * `<Leader>ww` -- 打开默认的 wiki 目录文件
- * `<Leader>wt` -- 通过tab实现上一个功能
+ * `<Leader>wt` -- 在新标签（Tab）中打开 wiki 目录文件
- * `<Leader>ws` -- 选择并且打开index文件
+ * `<Leader>ws` -- 在多个 wiki 中选择并打开该 wiki 的目录文件
- * `<Leader>wd` -- 删除进入的wiki文件
+ * `<Leader>wd` -- 删除当前 wiki 文件
- * `<Leader>wr` -- 重命名你进入的wiki文件
+ * `<Leader>wr` -- 重命名当前 wiki 文件
- * `<Enter>` -- 进入/创建 wiki 链接
+ * `<Enter>` -- 创建或打开 wiki 链接
- * `<Shift-Enter>` -- 通过分屏模式sp，进入/创建wiki链接
+ * `<Shift-Enter>` -- 先上下分屏再打开 wiki 链接（若非链接则先创建）
- * `<Ctrl-Enter>` -- 通过分屏模式vs，进入/创建wiki链接
+ * `<Ctrl-Enter>` -- 先左右分屏再打开 wiki 链接（若非链接则先创建）
- * `<Backspace>` -- 返回父节点
+ * `<Backspace>` -- 返回之前浏览的 wiki 文件
- * `<Tab>` -- 寻找下一个wiki链接
+ * `<Tab>` -- 跳到本文件中下一个 wiki 链接
- * `<Shift-Tab>` -- 寻找上一个wiki链接
+ * `<Shift-Tab>` -- 跳到本文件中上一个 wiki 链接
 
-查看`:h vimwiki-mappings`
+更多快捷键说明，请阅 `:h vimwiki-mappings`
 
 
 命令
 ------------------------------------------------------------------------------
 
- * `:Vimwiki2HTML` -- 转换当前wiki成为html
+ * `:Vimwiki2HTML` -- 将当前 wiki 文件转换成 HTML 网页
- * `:VimwikiAll2HTML` -- 转化你的全部wiki到html
+ * `:VimwikiAll2HTML` -- 把所有 wiki 文件转换成 HTML 网页
  * `:help vimwiki-commands` -- 显示全部命令
 
 
-安装细节
+安装
 ==============================================================================
 
-在安装之前，你需要做的
+准备工作
 ------------------------------------------------------------------------------
 
-确定在`vimrc`中，你的设置是这样的。
+确保在 `vimrc` 中加入了以下设置：
 
     set nocompatible
     filetype plugin on
     syntax on
 
-如果没有他们，Vimwiki将无法正常工作。
+没有这些设置，Vimwiki 将无法正常工作。
 
+通过 [Vim packages](http://vimhelp.appspot.com/repeat.txt.html#packages) 安装（Vim 7.4.1528 后）
+------------------------------------------------------------------------------
 
+    git clone https://github.com/vimwiki/vimwiki.git ~/.vim/pack/plugins/start/vimwiki
 
-使用 pathogen (译者注：一个插件) (http://www.vim.org/scripts/script.php?script_id=2332 )
+通过 [Pathogen](http://www.vim.org/scripts/script.php?script_id=2332) 安装
 ------------------------------------------------------------------------------
 
     cd ~/.vim
@@ -128,4 +130,32 @@ normal 模式:
     cd bundle
     git clone https://github.com/vimwiki/vimwiki.git
 
-然后启动vim，使用`:Helptags` 然后 `:help vimwiki`来确保他已经被安装了。
+通过 [Vim-Plug](https://github.com/junegunn/vim-plug) 安装
+------------------------------------------------------------------------------
+
+在 `vimrc` 中加入以下插件设置：
+
+    Plug 'vimwiki/vimwiki'
+
+然后运行 `:PlugInstall`。
+
+通过 [Vundle](https://github.com/VundleVim/Vundle.vim) 安装
+------------------------------------------------------------------------------
+
+在 `vimrc` 中加入 `Plugin 'vimwiki/vimwiki'`，然后执行：
+
+    vim +PluginInstall +qall
+
+或者下载 [zip 压缩包](https://github.com/vimwiki/vimwiki/archive/master.zip)然后解压到 `~/.vim/bundle/` 目录下。
+
+安装后，启动 Vim 并执行 `:Helptags` 以及 `:help vimwiki`，检查安装是否成功。
+
+
+获取帮助
+==============================================================================
+
+遇到问题？在 Freenode 的 IRC 频道 `#vimwiki`（[网页聊天](https://webchat.freenode.net/?channels=#vimwiki)）提问，或者发送问题到[邮件列表](https://groups.google.com/forum/#!forum/vimwiki)上吧。
+
+
+----
+\* 前面截图中用的是 [solarized 配色方案](https://github.com/altercation/vim-colors-solarized)以及 [lightline](https://github.com/itchyny/lightline.vim) 插件。

README.md

@@ -1,6 +1,8 @@
 A Personal Wiki For Vim
 ==============================================================================
 
+[中文](README-cn.md)
+
 ![screenshot1](doc/screenshot_1.png)
 ![screenshot2](doc/screenshot_2.png) *
 
@@ -153,7 +155,7 @@ Installation using [Vim-Plug](https://github.com/junegunn/vim-plug)
 
 Add the following to the plugin-configuration in your vimrc:
 
-    Plug 'vimwiki/vimwiki', { 'branch': 'dev' }
+    Plug 'vimwiki/vimwiki'
 
 Then run `:PlugInstall`.
 
@@ -172,8 +174,13 @@ Then launch Vim, run `:Helptags` and then `:help vimwiki` to verify it was insta
 Getting help
 ==============================================================================
 
-Have a question? Visit the IRC channel `#vimwiki` on Freenode ([webchat](https://webchat.freenode.net/?channels=#vimwiki))
+Have a question? Visit the IRC channel `#vimwiki` on Freenode ([webchat](https://webchat.freenode.net/?channels=#vimwiki), also synced to Matrix/Riot: `#freenode_#vimwiki:matrix.org`) or post to the [mailing list](https://groups.google.com/forum/#!forum/vimwiki).
-or post to the [mailing list](https://groups.google.com/forum/#!forum/vimwiki).
+
+Helping Vimwiki
+==============================================================================
+
+Vimwiki has a lot of users but only very few recurring developers or people helping the community. Your help is therefore appreciated. Everyone can help! See [#625](https://github.com/vimwiki/vimwiki/issues/625) for information on how you can help.
+
 
 
 ----

autoload/vimwiki/base.vim

@@ -152,7 +152,13 @@ function! vimwiki#base#resolve_link(link_text, ...)
       let link_infos.anchor = join(split_lnk[1:], '#')
     endif
     if link_text == ''  " because the link was of the form '#anchor'
-      let link_text = fnamemodify(source_file, ':p:t:r')
+      let expected_ext = vimwiki#u#escape(vimwiki#vars#get_wikilocal('ext')).'$'
+      if source_file =~# expected_ext
+          " Source file has expected extension. Remove it, it will be added later on
+          let ext_len = strlen(vimwiki#vars#get_wikilocal('ext'))
+          let link_text = fnamemodify(source_file, ':p:t')[:-ext_len-1]
+      endif
+
     endif
   endif
 

autoload/vimwiki/html.vim

@@ -1072,7 +1072,9 @@ function! s:process_tag_h(line, id)
         let h_text = num.' '.h_text
       endif
       let h_complete_id = s:escape_html_attribute(h_complete_id)
-      let h_part = '<div id="'.h_complete_id.'"><h'.h_level.' id="'.h_id.'"'
+      let h_part  = '<div id="'.h_complete_id.'">'
+      let h_part .= '<h'.h_level.' id="'.h_id.'" class="header">'
+      let h_part .= '<a href="#'.h_complete_id.'"'
 
     else
 
@@ -1088,7 +1090,7 @@ function! s:process_tag_h(line, id)
 
     let h_text = s:process_inline_tags(h_text, a:id)
 
-    let line = h_part.h_text.'</h'.h_level.'></div>'
+    let line = h_part.h_text.'</a></h'.h_level.'></div>'
 
     let processed = 1
   endif

autoload/vimwiki/style.css

@@ -25,6 +25,7 @@ del {text-decoration: line-through; color: #777777;}
 .justcenter {text-align: center;}
 .center {margin-left: auto; margin-right: auto;}
 .tag {background-color: #eeeeee; font-family: monospace; padding: 2px;}
+.header a {text-decoration: none; color: inherit;}
 
 /* classes for items of todo lists */
 .rejected {

autoload/vimwiki/vars.vim

@@ -85,8 +85,8 @@ function! s:populate_global_variables()
   " this regexp defines what can form a link when the user presses <CR> in the
   " buffer (and not on a link) to create a link
   " basically, it's Ascii alphanumeric characters plus #|./@-_~ plus all
-  " non-Ascii characters
+  " non-Ascii characters, except that . is not accepted as the last character
-  let g:vimwiki_global_vars.rxWord = '[^[:blank:]!"$%&''()*+,:;<=>?\[\]\\^`{}]\+'
+  let g:vimwiki_global_vars.rxWord = '[^[:blank:]!"$%&''()*+,:;<=>?\[\]\\^`{}]*[^[:blank:]!"$%&''()*+.,:;<=>?\[\]\\^`{}]'
 
   let g:vimwiki_global_vars.rx_wikilink_prefix1 = g:vimwiki_global_vars.rx_wikilink_prefix .
         \ g:vimwiki_global_vars.rxWikiLinkUrl . g:vimwiki_global_vars.rx_wikilink_separator

doc/vimwiki.txt

@@ -707,7 +707,7 @@ Vimwiki file.
 *:VimwikiGoto*
     Goto link provided by an argument. For example: >
         :VimwikiGoto HelloWorld
-<    opens opens/creates HelloWorld wiki page.
+<    opens/creates HelloWorld wiki page.
 
     Supports |cmdline-completion| for link name.
 
@@ -1423,7 +1423,7 @@ Hit |zr| one more time :
 
 Note: If you use the default Vimwiki syntax, folding on list items will work
 properly only if all of them are indented using the current 'shiftwidth'.
-For MediaWiki syntax, * or # should be in the first column.
+For Markdown and MediaWiki syntax, * or # should be in the first column.
 
 To turn folding on/off check |g:vimwiki_folding|.
 
@@ -2280,8 +2280,8 @@ local mappings |vimwiki_glstar|, |vimwiki_gl#| |vimwiki_gl-|, |vimwiki_gl-|,
 |vimwiki_gl1|, |vimwiki_gla|, |vimwiki_glA|, |vimwiki_gli|, |vimwiki_glI| and
 |vimwiki_i_<C-L>_<C-M>|.
 
-Note: if you use MediaWiki syntax, you probably would like to set this option
+Note: if you use Markdown or MediaWiki syntax, you probably would like to set
-to 0, because every indented line is considered verbatim text.
+this option to 0, because every indented line is considered verbatim text.
 
 
 *vimwiki-option-auto_tags*
@@ -2321,7 +2321,7 @@ Global options are configured using the following pattern: >
 Highlight headers with =Reddish=, ==Greenish==, ===Blueish=== colors.
 
 Value           Description~
-1               Use VimwikiHeader1-VimwikiHeader6 group colors to highlight
+1               Use VimwikiHeader1 - VimwikiHeader6 group colors to highlight
                 different header levels.
 0               Use |hl-Title| color for headers.
 Default: 0
@@ -2338,11 +2338,13 @@ Highlight checked list items with a special color:
 
 Value           Description~
 0               Don't highlight anything.
-1               Highlight checked [X] list item with |group-name| "Comment".
+1               Highlight only the first line of a checked [X] list item.
-2               Highlight checked [X] list item and all its child items.
+2               Highlight a complete checked list item and all its child items.
 
 Default: 0
 
+The |group-name| "Comment" is used for highlighting.
+
 Note: Option 2 does not work perfectly.  Specifically, it might break if the
 list item contains preformatted text or if you mix tabs and spaces for
 indenting.  Also, indented headers can be highlighted erroneously.
@@ -2957,7 +2959,7 @@ Contributors and their Github usernames in roughly chronological order:
     - Daniel Trnka (@trnila)
     - Yuchen Pei (@ycpei)
     - @maqiv
-    - @dpc
+    - Dawid Ciężarkiewicz (@dpc)
     - Drew Hays (@Dru89)
     - Daniel Etrata (@danetrata)
     - Keith Haber (@kjhaber)
@@ -2971,6 +2973,21 @@ Contributors and their Github usernames in roughly chronological order:
     - Zhuang Ma (@mzlogin)
     - Huy Le (@huynle)
     - Nick Borden (@hcwndbyw)
+    - John Campbell (@johnmarcampbell)
+    - Petrus (@PetrusZ)
+    - Steven Stallion (@sstallion)
+    - Daniel Quomsieh (@DQuomsieh)
+    - Fredrik Arnerup (@farnerup)
+    - CUI Hao (@cuihaoleo)
+    - Benjamin Brandtner (@BenjaminBrandtner)
+    - @sreejith994
+    - Raphael Feng (@raphaelfeng)
+    - Kasper Socha (@fte10kso)
+    - Nicolas Brailovsky (@nicolasbrailo)
+    - @BenMcH
+    - Stefan Huber (@shuber2)
+    - Hugo Hörnquist (@HugoNikanor)
+    - Rane Brown (@ranebrown)
 
 
 ==============================================================================
@@ -2983,7 +3000,7 @@ http://code.google.com/p/vimwiki/issues/list. They may be accessible from
 https://github.com/vimwiki-backup/vimwiki/issues.
 
 
-2.4 (not yet released)~
+2.4 (2019-03-24)~
 
 New:~
     * Add the option |g:vimwiki_text_ignore_newline|.
@@ -3003,6 +3020,8 @@ New:~
     * Add the %date placeholder, see |vimwiki-date|.
     * Add the option |vimwiki-option-custom_wiki2html_args|.
     * Add support for HTML-style comments when using markdown syntax.
+    * Made headings link to themselves in HTML output.
+    * Add |:VimwikiShowVersion| to check the version
 
 Removed:~
     * Remove the undocumented and buggy command :VimwikiReadLocalOptions
@@ -3027,6 +3046,10 @@ Fixed:~
     * Opening the diary and wikis from the menu works correctly now.
     * Issue #497: Make |:VimwikiMakeDiaryNote| work outside a wiki buffer.
     * Use markdown syntax in the diary when appropriate.
+    * Improve handling of errors on opening files.
+    * Update links when renaming a page with |:VimwikiRenameLink|.
+    * Fix losing the highlighting in various situations.
+    * Improved link normalisation.
     * Various other minor fixes.
 
 
@@ -3249,7 +3272,7 @@ http://code.google.com/p/vimwiki/issues/list
     * Issue 210: HTML: para enclose header.
     * Issue 214: External links containing Chinese characters get trimmed.
     * Issue 218: Command to generate HTML file and open it in webbrowser. See
-      |:Vimwiki2HTMLBrowse|(bind to <leader>whh)
+      |:Vimwiki2HTMLBrowse|(bind to <Leader>whh)
     * NEW: Added <Leader>wh mapping to call |:Vimwiki2HTML|
 
 

plugin/vimwiki.vim

@@ -9,6 +9,11 @@ if exists("g:loaded_vimwiki") || &cp
 endif
 let g:loaded_vimwiki = 1
 
+" Set to version number for release, otherwise -1 for dev-branch
+let s:plugin_vers = 2.4
+
+" Get the directory the script is installed in
+let s:plugin_dir = expand('<sfile>:p:h:h')
 
 let s:old_cpo = &cpo
 set cpo&vim
@@ -188,6 +193,23 @@ function! s:set_windowlocal_options()
 endfunction
 
 
+function! s:get_version()
+  if s:plugin_vers != -1
+    echo "Stable version: " . s:plugin_vers
+  else
+    let a:plugin_rev    = system("git --git-dir " . s:plugin_dir . "/.git rev-parse --short HEAD")
+    let a:plugin_branch = system("git --git-dir " . s:plugin_dir . "/.git rev-parse --abbrev-ref HEAD")
+    let a:plugin_date   = system("git --git-dir " . s:plugin_dir . "/.git show -s --format=%ci")
+    if v:shell_error == 0
+      echo "Branch: " . a:plugin_branch
+      echo "Revision: " . a:plugin_rev
+      echo "Date: " . a:plugin_date
+    else
+      echo "Unknown version"
+    endif
+  endif
+endfunction
+
 
 
 " Initialization of Vimwiki starts here. Make sure everything below does not
@@ -281,6 +303,8 @@ command! -count=1 VimwikiMakeTomorrowDiaryNote
 command! VimwikiDiaryGenerateLinks
       \ call vimwiki#diary#generate_diary_section()
 
+command! VimwikiShowVersion call s:get_version()
+
 
 
 let s:map_prefix = vimwiki#vars#get_global('map_prefix')